-
Notifications
You must be signed in to change notification settings - Fork 64
Testing https://github.com/jenkinsci/jackson2-api-plugin/pull/311 #5622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jtnord thanks very much for running this build. It shows a problem that is unrelated to this change but will affect this week's plugin BOM build. The ci.jenkins.io agents that run these builds have now upgraded to command line git 2.51.0. That's a desirable change, but it shows a bug in git client plugin releases prior to 6.3.1. Prior to 6.3.1, the git client plugin assumes the "git whatchanged" command is available. Command line git 2.51.0 drops the "git whatchanged" command. Git client plugin 6.3.0 and later require Jenkins 2.504.1. That means tests of the 2.492.x line are using a git client plugin version that does not support CLI git 2.51.0. Alternatives that come to mind:
There may be other options as well. @basil or @darinpope do you have any alternative recommendations? |
|
My preference is for a backport of jenkinsci/git-client-plugin#1327 to the 2.492.x line, since this affects production users as well. |
|
Beware of github-api that might require a release to support jackson 2.20.0. See |
Jackson API 2.20.0 removes the PropertyNamingStrategy.SNAKE_CASE symbol. The replacement symbol is PropertyNamingStrategies.SNAKE_CASE. Refer to BOM test failures in: * jenkinsci/bom#5622 Testing done: Confirmed it compiles with Jackson 2 API 2.20.0 incremental build and with current Jackson 2 API 2.19.x.
Jackson API 2.20.0 removes the PropertyNamingStrategy.SNAKE_CASE symbol. The replacement symbol is PropertyNamingStrategies.SNAKE_CASE. Refer to BOM test failures in: * jenkinsci/bom#5622 Testing done: Confirmed it compiles with Jackson 2 API 2.20.0 incremental build and with current Jackson 2 API 2.19.x.
Jackson API 2.20.0 removes the PropertyNamingStrategy.SNAKE_CASE symbol. The replacement symbol is PropertyNamingStrategies.SNAKE_CASE. Refer to BOM test failures in: * jenkinsci/bom#5622 Testing done: Confirmed it compiles with Jackson 2 API 2.20.0 incremental build and with current Jackson 2 API 2.19.x. Co-authored-by: Basil Crow <[email protected]> Co-authored-by: Kris Stern <[email protected]>
|
@jtnord These plugins have been released and adopted in BOM:
The most recent PR build is passing except for a failure in As far as references to From an open-source Jenkins perspective, I think jenkinsci/jackson2-api-plugin#311 is ready for merge/release. |
Many thanks for the analysis and the reminder |
|
Closing this pull request because gitlab-api has been updated to handle Jackson 2.20.0. The updated version will be included in the next release of the plugin BOM. Refer to JENKINS-76091 and its linked pull requests for more details. |
Testing jenkinsci/jackson2-api-plugin#311
Testing done
Submitter checklist